Comments on: Removing Rails validations with metaprogramming

By: Casper Fabricius

Casper Fabricius — Thu, 18 Feb 2010 08:04:28 +0000

Ben, that looks awesome. Any chance you can change it into a plugin so it can be used in any Rails project?

By: Ben Evans

Ben Evans — Wed, 17 Feb 2010 20:55:35 +0000

After doing some more playing around with your method and the one I linked in my previous comment, I have created a Radiant extension that allows targeted removal of default validators without any “hack” style methods.

Using this extension, you can clear validations, or override targeted validations easily on Radiant core models. It does not take much more to also extend / override validations in extension models.

http://github.com/JediFreeman/Radiant-Validators-Extension

By: Ben Evans

Ben Evans — Fri, 12 Feb 2010 01:57:34 +0000

I was playing with trying to modify the validation for the slug on radiant pages, it currently does not allow anything but numbers/letters… I could not get your script working with my code, but I was able to get this guy’s solution working. The downside is that in my PageExtension class, I had to put all the validations from the Radiant Page class in the process. http://www.neverlet.be/2009/2/18/active-record-validations-are-callbacks

By: Casper Fabricius

Casper Fabricius — Sun, 22 Feb 2009 15:40:17 +0000

Nice solution, Will – I actually like that better than mine for this particular case. It is cleaner as you say, and easier to read and understand – less magic. Still, I mostly blogged about my solution because I found it an interesting study into how far you can go with Ruby :)

By: Will

Will — Sun, 22 Feb 2009 13:26:57 +0000

Hello Casper. Very interesting that so many of us are working on this. Here’s what I ended up with. It seems a cleaner way but without as much control as your later intervention.

To be included into ActiveRecord::Validations::ClassMethods:

module MultiSite::ScopedValidation


  def self.included(base)
    def validates_uniqueness_of_with_site(*attr)

      if column_names.include?('site_id')

        configuration = attr.extract_options!

        configuration[:scope] ||= :site_id

        attr.push(configuration)

      end

      validates_uniqueness_of_without_site(*attr)

    end
    base.alias_method_chain :validates_uniqueness_of, :site

end end

I really don’t like the site_id assumption, but afaik validations are hit too early in the initialization sequence for anything more properly configurable to work. Would love to be wrong about that.

This is from a fork of multi_site that I’m using to provide site-scoping to other extensions. I’d be very glad of any comments. http://github.com/spanner/radiant-multi-site-extension

By: AC

AC — Fri, 23 Jan 2009 20:19:19 +0000

Looks good. I might have to use this for some crap validation that some plugins/gems have for email which deny valid RFC822 emails.

By: Aditya

Aditya — Wed, 10 Dec 2008 03:52:45 +0000

haha – nope, I was going to propose we coerce^Wconvince Sean to add it to Radiant ;-)

Great work on the extensions though, Josh Hart clued me in…

By: Casper Fabricius

Casper Fabricius — Sun, 07 Dec 2008 10:01:01 +0000

It is a hack, and an ugly one at that, but since I was writing an extension to be released, I could not rely on changing someone else’s code.

All changes had to be done from my code, but if you have a trick up your sleeve for adding that :if => without modifying existing code I’d like to see it :)

By: Aditya

Aditya — Sun, 07 Dec 2008 08:35:51 +0000

Whoa. I was running into the exact same thing with mutli_site – login seems to be unque in the User model and there’s no good way of removing the validation. The thing I’m proposing is to add an :if => should_validate_unique_login but I’m not so sure if that’s the best option…

Overriding validations just seems like a hack.